8000 Depends on old version of @storybook/addons · Issue #3 · bitttttten/storybook-mock-date-decorator · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Depends on old version of @storybook/addons #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dominics opened this issue Jan 18, 2024 · 6 comments · Fixed by #4
Closed

Depends on old version of @storybook/addons #3

dominics opened this issue Jan 18, 2024 · 6 comments · Fixed by #4

Comments

@dominics
Copy link
dominics commented Jan 18, 2024 •
edited
Loading

storybook-mock-date-decorator/package.json

Line 14 in 33066fe

"@storybook/addons": "^6.4.19",

While attempting an upgrade to Storybook 7.x, the automigrate/upgrade helper complains:

││   Critical: The following dependencies are duplicated and WILL cause unexpected behavior:                                                  
││ 
││   @storybook/core-events:                                                                                                                   
││   7.6.9, 6.5.16                                                                                                                             
||                                                                                                                                   
││   Attention: The following dependencies are duplicated which might cause unexpected behavior:                                               
││                                                                                                                                            
││   @storybook/channels:                                                                                                                      
││   7.6.9, 6.5.16

Running yarn why indicates this is because of the dependency in this package:

=> Found "@storybook/addons#@storybook/core-events@6.5.16"
info This module exists because "_project_#project-name#storybook-mock-date-decorator#@storybook#addons" depends on it.

=> Found "@storybook/addons#@storybook/channels@6.5.16"
info This module exists because "_project_#project-name#storybook-mock-date-decorator#@storybook#addons" depends on it.

Maybe it should instead be a peer-dependency?
@david-morris
Copy link
david-morris commented Feb 2, 2024 •
edited
Loading

This is also a problem for me. This major version change does actually matter, since makeDecorator is exported from a different package in storybook 7.

Specifically, both makeDecorator and MakeDecoratorResult are exported from @storybook/preview-api.

@bitttttten
Copy link
Owner

gotcha okay. npm dependencies were a bit of a mystery back then for me. @david-morris @dominics i'll add it as a peer dependency and publish it on the weekend when i am back at my laptop 🤙

@Adrii77
Copy link
Adrii77 commented Feb 21, 2024

Same problem here ! : /

@fernandopasik fernandopasik mentioned this issue Mar 18, 2024
Merged
@fernandopasik
Copy link
Contributor

@bitttttten I've contributed a PR to solve this issue, let me know if you are happy with it

@bitttttten
Copy link
Owner

thank you! i will aim to merge it in the morning:)

@bitttttten
Copy link
Owner
bitttttten commented Mar 21, 2024 •
edited
Loading

hey all, please try v1.0.2 🙏

looks fixed from here! lmk if not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move @storybook/addons to peer dependencies
5 participants
@dominics @fernandopasik @david-morris @bitttttten @Adrii77
0