8000 Upgrade to PHP 8.4 DOM · Issue #4 · brick/structured-data · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Upgrade to PHP 8.4 DOM #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
adamjgriffith opened this issue May 5, 2025 · 3 comments
Open

Upgrade to PHP 8.4 DOM #4

adamjgriffith opened this issue May 5, 2025 · 3 comments

Comments

@adamjgriffith
Copy link

PHP 8.4 has been released with a rewrite to the ext-dom extension. These classes are compatible with HTML 5 and are WHATWG spec-compliant; solving long-standing bugs in the DOM extension.

See: https://www.php.net/manual/en/migration84.new-features.php#migration84.new-features.dom

Would you consider a PR to upgrade this package?
@BenMorel
Copy link
Member
BenMorel commented May 6, 2025

Hi, yes I would most definitely accept a PR! How do you see this?

  • use the new DOM API when PHP >= 8.4 is detected, and fall back to the old API otherwise
  • or require PHP 8.4 from now on?

@adamjgriffith
Copy link
Author

I would imagine as this package receives little updates we could just bump the major (minor in this case as it's still 0.x) and enforce a PHP 8.4 minimum version. What do you think?

@BenMorel
Copy link
Member
BenMorel commented May 6, 2025

I don't mind bumping the minimum requirement to 8.4. This package doesn't have many users yet, and I'm about to do the same for brick/geo anyway, as I will need PHP 8.4 feature for the next version, too.

4635
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BenMorel @adamjgriffith
0