8000 Use bytes.Buffer to output compiled string instead of normal string concatenation · Issue #66 · c9s/c6 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use bytes.Buffer to output compiled string instead of normal string concatenation #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
c9s opened this issue May 23, 2015 · 5 comments
Open

Use bytes.Buffer to output compiled string instead of normal string concatenation #66

c9s opened this issue May 23, 2015 · 5 comments
Labels
Improvement
Milestone
Pre-Release

Comments

@c9s
Copy link
Owner
c9s commented May 23, 2015

No description provided.

@c9s c9s added this to the Pre-Release milestone May 23, 2015
@drewwells
Copy link

👍

@c9s
Copy link
Owner Author
c9s commented May 24, 2015

Currently appending compiled output on the top layer in commit 1353a11

@drewwells
Copy link

Looks great, would it be sufficient to make this a io.Writer? Then it would be easy to pass in a filewriter, http.ResponseWriter or os.Stdout.

@drewwells
Copy link

Supporting this API would be very nice func Compile(dst Writer, src Reader) (written int64, err error)

Then c6 supports Sass coming in and CSS coming out streaming fashion. The actual buffers wouldn't matter just as long as it supports .Read() in and .Write() out.

@c9s
Copy link
Owner Author
c9s commented May 24, 2015

Sounds great! but I am currently working on the function call evaluation, any PRs of this is welcome. 👍

@c9s c9s mentioned this issue Sep 18, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
Pre-Release
Development

No branches or pull requests
2 participants
@c9s @drewwells
0