8000 feat: support observed address advertisement, disable tls server by fbozic · Pull Request #1254 · calimero-network/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: support observed address advertisement, disable tls server #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

feat: support observed address advertisement, disable tls server #1254

merged 1 commit into from
May 15, 2025

Conversation

fbozic
Copy link
Member
@fbozic fbozic commented May 8, 2025 •
edited
Loading

Description

Add support for advertisement of public observed addresses.
Remove support for TLS server which fixes port already in use.

Test Plan

Multiple runs of GHA e2e tests passed.
Works on ubuntu ec2 machine.

Documentation Update

N/A

@fbozic fbozic self-assigned this May 8, 2025
@fbozic fbozic force-pushed the release/feat/merod-public branch from 32db62e to 75fb89f Compare May 9, 2025 11:35
@fbozic fbozic changed the title feat(network): support observed address advertisement, disable tls server feat: support observed address advertisement, disable tls server May 9, 2025
@fbozic fbozic force-pushed the release/feat/merod-public branch 3 times, most recently from e0472fd to 83d1a27 Compare May 9, 2025 16:46
@fbozic fbozic marked this pull request as ready for review May 9, 2025 19:00
@fbozic fbozic force-pushed the release/feat/merod-public branch from 83d1a27 to 34744a4 Compare May 15, 2025 10:56
@github-actions GitHub Actions
Copy link

E2E tests report

Scenario: ethereum

Protocol/Step 0. app install (AllMembers) 1. ctx create 2. alias create 3. call (set, Inviter) 4. call (get, Inviter) 5. ctx invite-join 6. wait (Consensus) 7. call (get, AllMembers) 8. call (set, Inviter) 9. wait (Broadcast) 10. call (get, AllMembers)
ethereum ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅

Scenario: icp

Protocol/Step 0. app install (AllMembers) 1. ctx create 2. ctx invite-join 3. wait (Consensus) 4. call (create_new_proposal, Inviter) 5. get proposals 6. call (send_proposal_messages, Inviter) 7. wait (Broadcast) 8. call (get_proposal_messages, Invitees) 9. call (approve_proposal, Invitees) 10. verify external state
icp ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅

Scenario: near

Protocol/Step 0. app install (AllMembers) 1. ctx create 2. ctx invite-join 3. wait (Consensus) 4. call (create_new_proposal, Inviter) 5. get proposals 6. call (send_proposal_messages, Inviter) 7. wait (Broadcast) 8. call (get_proposal_messages, Invitees) 9. call (approve_proposal, Invitees) 10. verify external state
near ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅

Scenario: stellar

Protocol/Step 0. app install (AllMembers) 1. ctx create 2. ctx invite-join 3. wait (Consensus) 4. call (create_new_proposal, Inviter) 5. get proposals 6. call (approve_proposal, Invitees) 7. verify external state 8. call (create_new_proposal, Inviter) 9. get proposals 10. call (send_proposal_messages, Inviter) 11. wait (Broadcast) 12. call (get_proposal_messages, Invitees)
stellar ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅

@fbozic fbozic requested review from alenmestrov, miraclx and frdomovic and removed request for alenmestrov May 15, 2025 11:33
@fbozic fbozic merged commit 9466a18 into master May 15, 2025
21 checks passed
@fbozic fbozic deleted the release/feat/merod-public branch May 15, 2025 14:16
@fbozic fbozic mentioned this pull request May 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alenmestrov alenmestrov alenmestrov approved these changes

@frdomovic frdomovic frdomovic approved these changes

@miraclx miraclx Awaiting requested review from miraclx

Assignees

@fbozic fbozic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fbozic @alenmestrov @frdomovic
0