8000 Don't suppress warnings for experimental Kotlin features · Issue #17 · cashapp/contour · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Don't suppress warnings for experimental Kotlin features #17

Open
Egorand opened this issue Aug 31, 2019 · 2 comments
Open

Don't suppress warnings for experimental Kotlin features #17

Egorand opened this issue Aug 31, 2019 · 2 comments

Comments

@Egorand
Copy link
Collaborator
Egorand commented Aug 31, 2019

Since Contour is using experimental features (inline classes), it should be either propagating the warnings through annotations or Gradle flags (see Experimental API markers), or introducing its own experimental annotation (see an example of this in KotlinPoet). An argument in favor of a library-specific annotation is that developers might be fine with using experimental features in their own code, but reluctant to use 3rd party libraries that use them, hence the library should require explicit opt-in.

@saket
Copy link
Collaborator
saket commented Jun 13, 2020

If apps are reluctant to use libraries that depend on inline classes then they'll have to avoid contour entirely because it uses them for describing layout specs. Should we instead call-it out in the readme?

@JakeWharton
Copy link
Contributor

I think that would be wise in addition to correctly propagating either the built-in inline class opt-in annotation onto callers or defining your own.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
0