8000 CSV line recovery forces Windows line endings · Issue #1597 · certtools/intelmq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
CSV line recovery forces Windows line endings #1597
New issue
New issue
Closed
Bug
#2280
Closed
CSV line recovery forces Windows line endings#1597
Bug
#2280
Labels
bugIndicates an unexpected problem or unintended behaviorcomponent: corehelp wantedIndicates that a maintainer wants help on an issue or pull request
@sinus-x

Description

@sinus-x
sinus-x
opened on Aug 14, 2020

The recover_line_csv() function is joining data with \r\n, redgardless of the source file newlines:

intelmq/intelmq/lib/bot.py

Line 1042 in a2d20df

tempdata = '\r\n'.join(self.tempdata) + '\r\n' if self.tempdata else ''

This means that bot test are failing even though the parsing succeeded, because the raw values do not match: there is a new CR byte. As a workaround, bot tests are replacing newlines in their test files to account for that, which is not ideal solution.

intelmq/intelmq/tests/bots/parsers/generic/test_parser_csv_data_type.py

Line 20 in f7a5c7a

"raw": utils.base64_encode(SAMPLE_FILE.replace('\n', '\r\n')),

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugIndicates an unexpected problem or unintended behaviorcomponent: corehelp wantedIndicates that a maintainer wants help on an issue or pull request

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      0