Permalink
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 16 commits
- 31 files changed
- 2 contributors
Commits on Sep 5, 2021
Commits on Jan 17, 2023
-
-
rm2svg: split stream parsing from SVG dump
Tested: Made sure all the .rm files in the repo (non-version=6) produce the exact same SVG files. Before: ``` $ find rm_tools -type f -iname '*.rm' | xargs -i sh -c 'python rm_tools/rm2svg.py -i {} -o /tmp/foo.svg && md5sum /tmp/foo.svg' | sort | md5sum 9d7f1647b4f5a428900fb4c68d9da6ce - ``` After: ``` $ find rm_tools -type f -iname '*.rm' | xargs -i sh -c 'python rm_tools/rm2svg.py -i {} -o /tmp/foo.svg && md5sum /tmp/foo.svg' | sort | md5sum 9d7f1647b4f5a428900fb4c68d9da6ce - ``` -
Tested: ``` $ flake8 rm_tools/rm2svg.py | grep -v E501 $ ``` Note that we're ignoring E501 (line too long) as the right solution is black, which we will do in the next patch. Also made sure all the .rm files in the repo (non-version=6) produce the exact same SVG files. Before: ``` $ find rm_tools -type f -iname '*.rm' | xargs -i sh -c 'python rm_tools/rm2svg.py -i {} -o /tmp/foo.svg && md5sum /tmp/foo.svg' | sort | md5sum 9d7f1647b4f5a428900fb4c68d9da6ce - ``` After: ``` $ find rm_tools -type f -iname '*.rm' | xargs -i sh -c 'python rm_tools/rm2svg.py -i {} -o /tmp/foo.svg && md5sum /tmp/foo.svg' | sort | md5sum 9d7f1647b4f5a428900fb4c68d9da6ce - ``` -
rm2svg: fix indentation in SVG output
Includes: * make indentation coherent * add comments to SVG to make it more readable * replace .format-based strings with f-strings * fix a typo ("Mechanical" instead of "Machanical") Tested: Run parser before and after, and checked that the only difference is the indentation and the comments. Also: ``` $ find rm_tools -type f -iname '*.rm' | xargs -i sh -c 'python rm_tools/rm2svg.py -i {} -o /tmp/foo.svg && md5sum /tmp/foo.svg' | sort | md5sum 89fea1bc81d3925f5d049f2cc41a66c2 - ``` -
-
-
rm2svg: minor variable renaming
"y_width" is also known as "height". "x_width" is also known as "width". Tested: ``` $ find rm_tools -type f -iname '*.rm' | xargs -i sh -c 'python rm_tools/rm2svg.py -i {} -o /tmp/foo.svg && md5sum /tmp/foo.svg' | sort | md5sum 89fea1bc81d3925f5d049f2cc41a66c2 - ``` -
rm2svg: make python script executable
Also fix the README with how to run a command. Tested: ``` $ rm_tools/rm2svg.py -i ./rm_tools/convert_procedure/paper/93ce11cf-31e6-4a6c-ac67-7214c6be96ab.rm -o /tmp/foo.svg ```
-
-
-
rmtool: add support for lines v6
Includes: (1) .content file changes * json["formatVersion"] field set to 2 * json["pages"] field disappears. List of pages can be obtained from json["cPages"]["pages"][]["id"] (2) tries to use [rmscene](https://github.com/chemag/rmscene) to convert version=6 lines (.rm) files.
-
rmtool: do not look for deleted pages
Tested: Converted my whole repository of .rm files.
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...master