8000 Fix no source and lineno was set to caption of table [SF:patches:137] · Issue #162 · chrisjsewell/docutils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix no source and lineno was set to caption of table [SF:patches:137] #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chrisjsewell opened this issue Aug 9, 2020 · 0 comments
Closed

Comments

@chrisjsewell
Copy link
Owner

author: tk0miya
created: 2017-02-18 05:23:28.497000
assigned: None
SF_url: https://sourceforge.net/p/docutils/patches/137

attachments:

In Sphinx, we use source and line information of text nodes for I18N feature.

In docutils-0.13.2, it seems a caption of table does not have both attributes. The table node (parent) don't have also.
The attached patch sets the source and line information to the caption node.

Could you review this please?

Note: it seems there are no test cases for source and lines. So I simply added the directive code. Please let me know if any good place to do that.

Thanks,


commenter: darklite09
posted: 2017-02-20 08:19:20.984000
title: #137 Fix no source and lineno was set to caption of table

Related: https://sourceforge.net/p/docutils/feature-requests/41/


commenter: milde
posted: 2017-02-28 12:20:34.140000
title: #137 Fix no source and lineno was set to caption of table

  • status: open --> closed-fixed

commenter: milde
posted: 2017-02-28 12:20:34.460000
title: #137 Fix no source and lineno was set to caption of table

Applied in Revision 8039.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant
0