Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 7 commits
- 2 files changed
- 2 contributors
Commits on May 20, 2025
-
This commit enhances `Browser` logic within `pkg/browser` to detect supported and possibly supported URL schemes / protocols. If a URL is presented that doesn't match a known supported scheme/protocol, then `Browse(string) error` will check if the provided URL matches a file or directory on the filesystem. Erring if this matches anything we can find on the filesystem.
Commits on May 22, 2025
-
Enhance OS-specific browser tests, PR feedback
This commit addresses @babakks feedback in the PR of splitting out Windows and Unix/Linux specific browser tests from the shared common tests as well as minor restructuring of test setup / teardown logic.
Commits on May 27, 2025
-
Test refactor, refine errors, remove VSCode fix
This commit is focused on PR feedback: 1. Undoing the fix for running package tests within VSCode The "Run package tests" action within VSCode uses `-coverprofile` flag when invoking `go test`, which causes `TestBrowse` to error due to missing `GOCOVERDIR` env var. As this was called out as a problem in multiple tests, it felt like a larger problem to tackle outside of these changes. 2. Ensure browser test runs for Linux/Unix separately from Mac OS @babakks called out how the previous version of tests would fail on Linux when testing against Mac OS calculate app. This test has been reworked to separate Mac OS from Unix/Linux tests as well as consolidate the separate build specific test files back into a single file. 3. Improved `error` messages Rather than having a single, uniform error message from the various scenarios, this commit more nuanced error messages based on the different scenarios that are user-friendly. 4. Erring if URL is an executable on the path This is an additional defense in depth effort to guard against URLs that match executables found within the user's path. This leverages similar logic used elsewhere within `gh` for safely finding and executing commands.
Commits on May 29, 2025
-
-
Expand test cases for schem case sensitivity
This commit ensures that `HTTPS` and `https` are treated the same
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v2.12.0...v2.12.1