8000 Thanks @samcoe for the initial review! You are right that this call needs to happen earlier. · Issue #4 · cli/oauth · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Thanks @samcoe for the initial review! You are right that this call needs to happen earlier. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
KikeE36 opened this issue Jan 31, 2021 · 0 comments
Open

Thanks @samcoe for the initial review! You are right that this call needs to happen earlier. #4

KikeE36 opened this issue Jan 31, 2021 · 0 comments

Comments

@KikeE36
Copy link
KikeE36 commented Jan 31, 2021

Thanks @samcoe for the initial review! You are right that this call needs to happen earlier.

@divyaramanathan You will want to invoke the new API logic just before TemplateSurvey(), since that is where the user will be presented with a list of templates to choose between. Also, since the new API approach replaces looking up templates from the filesystem, you can remove the old filesystem lookups from this file.

Originally posted by @mislav in cli/cli#2539 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KikeE36
0