rpc: tracing interceptors in drpc

DRPC implementation of tracing interceptors
This issue is part of a goal to implement all the grpc interceptors within drpc.
This issue tracks implementation of client interceptors based on tracer, tagger in drpc.
Code references:

cockroach/pkg/rpc/context.go

Lines 599 to 623 in e3eb5f0

    
           if tracer := rpcCtx.Stopper.Tracer(); tracer != nil { 
        
           	// We use a decorator to set the "node" tag. All other spans get the 
        
           	// node tag from context log tags. 
        
           	// 
        
           	// Unfortunately we cannot use the corresponding interceptor on the 
        
           	// server-side of gRPC to set this tag on server spans because that 
        
           	// interceptor runs too late - after a traced RPC's recording had 
        
           	// already been collected. So, on the server-side, the equivalent code 
        
           	// is in setupSpanForIncomingRPC(). 
        
           	// 
        
           	tagger := func(span *tracing.Span) { 
        
           		span.SetTag("node", attribute.IntValue(int(rpcCtx.NodeID.Get()))) 
        
           	} 
        
           	if rpcCtx.ClientOnly { 
        
           		// client-only RPC contexts don't have a node ID to report nor a 
        
           		// cluster version to check against. 
        
           		tagger = func(span *tracing.Span) {} 
        
           	} 
        
           	rpcCtx.clientUnaryInterceptors = append(rpcCtx.clientUnaryInterceptors, 
        
           		grpcinterceptor.ClientInterceptor(tracer, tagger)) 
        
           	rpcCtx.clientStreamInterceptors = append(rpcCtx.clientStreamInterceptors, 
        
           		grpcinterceptor.StreamClientInterceptor(tracer, tagger)) 
        
           }

Jira issue: CRDB-49356

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if tracer := rpcCtx.Stopper.Tracer(); tracer != nil {
	// We use a decorator to set the "node" tag. All other spans get the
	// node tag from context log tags.
	//
	// Unfortunately we cannot use the corresponding interceptor on the
	// server-side of gRPC to set this tag on server spans because that
	// interceptor runs too late - after a traced RPC's recording had
	// already been collected. So, on the server-side, the equivalent code
	// is in setupSpanForIncomingRPC().
	//
	tagger := func(span *tracing.Span) {
	span.SetTag("node", attribute.IntValue(int(rpcCtx.NodeID.Get())))
	}

	if rpcCtx.ClientOnly {
	// client-only RPC contexts don't have a node ID to report nor a
	// cluster version to check against.
	tagger = func(span *tracing.Span) {}
	}

	rpcCtx.clientUnaryInterceptors = append(rpcCtx.clientUnaryInterceptors,
	grpcinterceptor.ClientInterceptor(tracer, tagger))
	rpcCtx.clientStreamInterceptors = append(rpcCtx.clientStreamInterceptors,
	grpcinterceptor.StreamClientInterceptor(tracer, tagger))
	}

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions