drpc: request compression support

gRPC support request/response compression and we use snappy compressor. Evaluate the need for the compression in DRPC and add it if needed.

cockroach/pkg/rpc/context.go

Lines 1551 to 1565 in 4c2a546

    
           // Request request compression. Note that it's the client that 
        
           // decides to opt into compressions; the server accepts either 
        
           // compressed or decompressed payloads, and the specific codec used 
        
           // is named in the request (so different clients can use different 
        
           // compression algorithms.) 
        
           // 
        
           // On a related note, this configuration uses our own snappy codec. 
        
           // We believe it works better than the gzip codec provided natively 
        
           // by grpc, although the specific reason is now lost to history. It 
        
           // would be possible to change/simplify this, and since it's for 
        
           // each client to decide changing this will not require much 
        
           // cross-version compatibility dance. 
        
           if rpcCtx.rpcCompression { 
        
           	dialOpts = append(dialOpts, grpc.WithDefaultCallOptions(grpc.UseCompressor((snappyCompressor{}).Name()))) 
        
           }

Jira issue: CRDB-51641

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	// Request request compression. Note that it's the client that
	// decides to opt into compressions; the server accepts either
	// compressed or decompressed payloads, and the specific codec used
	// is named in the request (so different clients can use different
	// compression algorithms.)
	//
	// On a related note, this configuration uses our own snappy codec.
	// We believe it works better than the gzip codec provided natively
	// by grpc, although the specific reason is now lost to history. It
	// would be possible to change/simplify this, and since it's for
	// each client to decide changing this will not require much
	// cross-version compatibility dance.
	if rpcCtx.rpcCompression {
	dialOpts = append(dialOpts, grpc.WithDefaultCallOptions(grpc.UseCompressor((snappyCompressor{}).Name())))
	}

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions