Open
Description
Rangefeed clients based on kvclient/rangefeed.Factory must explicitly set an OnInternalError handler to be notified of internal errors. Otherwise, when one of these errors are encountered the rangefeed will silently stop emitting events. The current error conditions are:
roachpb.BatchTimestampBeforeGCError: the rangefeed sent a batch request below the GC threshold.roachpb.MVCCHistoryMutationError: MVCC history was mutated by e.g.AddSSTable,ClearRange, orRevertRange.
Callers should add a callback using WithOnInternalError and handle these errors appropriately (as well as any future error conditions that may be added). Relevant callers include:
- SQL descriptor watcher
- SQL zone watcher
- SQL lease watcher
- SQL stats cache watcher
- Settings watcher
- Span config subscriber
CC @cockroachdb/sql-schema @irfansharif
Jira issue: CRDB-12744
Metadata
Metadata
Assignees
Labels
Anything in KV that doesn't belong in a more specific category.Relating to SQL table/db descriptor handling.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Likely to be a quick win for someone experienced.SQL Foundations Team (formerly SQL Schema + SQL Sessions)