Comparing changes
Open a pull request
- 7 commits
- 9 files changed
- 3 contributors
Commits on May 7, 2025
-
codegen: use cockroachdb/errors package
The `cockroachdb` linters don't allow using the standard `errors` package, even in generated `*_drpc.pb.go` files. This change replaces its usage in `UnimplementedServer` with `cockroachdb/errors` to comply with linting requirements.
Commits on May 29, 2025
-
drpcclient: add client interceptor support in drpc (#6)
Interceptors are not natively supported by drpc. Here, we add support for interceptors in drpc. The changes include definition of client interceptor interface types, logic to chain multiple unary/stream interceptors. This change also introduces a new struct `drpcclient.ClientConn` which satisfies the drpc.Conn interface, and decorates underlying drpc Connection object with interceptors. The struct drpcclient.ClientConn is defined such that it can be initialized with a dialer function which supplies underlying connection either concretely or from a pool. Functional options pattern is employed to provide flexibility with addition of unary and chain interceptors on ClientConn struct. Epic: CRDB-50378 Fixes: #146086
Commits on Jun 2, 2025
-
codegen: update
RecvMsgfor gRPC compatibility (#3)It's already here in the implementation of the StreamServer implementations but not available through interface, so essentially it's hidden. In this change we update its parameters to become compatible with gRPC and added that definition in the interface.
-
codegen: generate common interfaces for stream server and client (#2)
These interfaces contain the shared methods between DRPC and gRPC stream servers and clients as used in cockroach.
Commits on Jun 3, 2025
-
codegen: create RPC service interface with gRPC & DRPC adapters (#4)
Define a shared `RPC<Service>Client` interface to wrap both gRPC's `<Service>Client` and DRPC's `DRPC<Service>Client`. Streaming methods will also return the common `RPC<Service>_<Method>Client`. Adds two simple adapters: - `NewGRPC<Service>ClientAdapter` - `NewDRPC<Service>ClientAdapter` They implement `RPC<Service>Client`, so we can swap clients at runtime via the cluster setting.
Commits on Jun 18, 2025
-
drpcclient: create a clientconn wrapping drpc.Conn
Here, we are updating constructor of clientConn to take in a `drpc.Conn` type object instead of a supplier of `drpc.Conn`. This simplifies the usage/construction of clientConn, and moves the responsibility of invoking a supplier/dialer to the caller of constructor. This way, closing of drpcpool would be a clear duty of the caller of this constructor.
-
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main...main