8000 investigate and fix gap in crossversion tests · Issue #4732 · cockroachdb/pebble · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

investigate and fix gap in crossversion tests #4732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
6 tasks
RaduBerinde opened this issue May 16, 2025 · 2 comments
Open
6 tasks

investigate and fix gap in crossversion tests #4732

RaduBerinde opened this issue May 16, 2025 · 2 comments
Assignees
@RaduBerinde
Labels
A-storage T-storage

Comments

@RaduBerinde
Copy link
Member
RaduBerinde commented May 16, 2025 •
edited
Loading

#4727 was an egregious 24.2->master update bug but was not caught by crossversion tests. Investigate why and fix.

One possibility to check - do we never upgrade database formats (so all our table formats are as old as the first build in the chain)?

Jira issue: PEBBLE-447

I am making a list of things that need to be fixed:

  • TestMetaCrossVersion needs to pass a --previous-ops flag
  • TestMeta needs to fail if --initial-state is passed without --previous-ops (instead of silently ignoring the former)
  • Support starting from an initial state with WAL settings (currently the store path mismatch causes failures)
  • Support shared storage when starting from an initial store that didn't have shared storage enabled
  • Use the data dir for shared and external storage to retain objects
  • Use unique numbers in external object names so they don't collide
@RaduBerinde
Copy link
Member Author

Perhaps randomizing the chain length rather than always starting with the same first version would help too.

@RaduBerinde RaduBerinde self-assigned this May 21, 2025
@RaduBerinde
Copy link
Member Author

It looks like the test is completely broken. When TestMetaCrossVersion runs TestMeta, it does not pass a --previous-ops flag:
https://github.com/cockroachdb/pebble/blob/master/internal/metamorphic/crossversion/crossversion_test.go#L380

The initial state flags are silently ignored if --previous-ops flag isn't passed:
https://github.com/cockroachdb/pebble/blob/master/internal/metamorphic/metaflags/meta_flags.go#L301

I tried a manual run with the right flags but immediately ran into issues that have to do with wal failover:
reading "_meta/250520-195135.4683254040531/standard-024/data/wal": open wal/: file does not exist
or
directory "" may contain relevant WALs

This was referenced May 22, 2025
Merged
Merged
Merged
Merged
Merged
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RaduBerinde RaduBerinde

Labels
A-storage T-storage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RaduBerinde
0