Add ReconnectInterval option to Network plugin #732
Conversation
|
👍 |
|
definitely awesome! 💯 |
|
I believe #627 solves a different problem. #627 is trying to solve for the underlying network socket not being valid any more. For example
So it is trying to solve for changing source address. It does this by detecting the My patch is doing the opposite. It is trying to solve for the destination address changing. Basically if someone updated DNS so collectd.example.com points somewhere else. So they are complimentary I would say. |
|
Hi @johnf, thank you very much for your patch! I have two change requests and a nit ;-)
Nit: use a Thanks again and best regards :-) |
The Network plugin only performs DNS resolution at initialization. This can be problematic when trying to performs migrations of collectd infrastructure or when trying to create HA solutions which are dependant on DNS. The ReconnectInterval options forces a reconnect of all the sockets at the defined number of seconds. By default no re-connections are attempted if this option is not set.
|
@octo Thanks for the review. I've updated with your changes and rebased against master again. Let me know if you want any other changes. |
|
Thanks @johnf! |
see: collectd/collectd#732 Signed-off-by: Ricky Elrod <codeblock@fedoraproject.org>
The Network plugin only performs DNS resolution at initialization. This
can be problematic when trying to performs migrations of collectd
infrastructure or when trying to create HA solutions which are dependant
on DNS.
The ReconnectInterval options forces a reconnect of all the sockets at
the defined number of seconds. By default no re-connections are attempted
if this option is not set.