libstatgrab: only use one configure test for 0.90 API change #806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, each API change was tested in configure.ac. Some of the tests are relying on signature checks and would need to have -Werror flag enabled to make them work. This is quite fragile. Instead, we assume that if `sg_init()` requires an argument, we must use the 0.90 API. Fixes: collectd#795
vincentbernat
referenced
this pull request
in vincentbernat/collectd
Nov 17, 2014
… 0.9 In those versions, `sg_get_disk_io_stats()` need to be invoked a pointer to size_t instead of pointer to int. Such a requirement is detected at configure-time. Fixes: collectd#445
|
great to see configure.ac losing weight! |
pyr
added a commit
that referenced
this pull request
Nov 17, 2014
libstatgrab: only use one configure test for 0.90 API change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, each API change was tested in configure.ac. Some of the
tests are relying on signature checks and would need to have -Werror
flag enabled to make them work. This is quite fragile.
Instead, we assume that if
sg_init()requires an argument, we must usethe 0.90 API.
Fixes: #795
This is one possible fix for the problem introduced in c963d35