Adds IPC Plugin with documentation #925
Conversation
|
By the way, the old PR was #463 |
| shm_bytes_rss value:GAUGE:0:65535 | ||
| shm_bytes_swapped value:GAUGE:0:65535 | ||
| shm_bytes_total value:GAUGE:0:65535 | ||
| shm_segments value:GAUGE:0:65535 |
There was a problem hiding this comment.
@ajdiaz we're trying to avoid infinite multiplication of the amount of entries in types.db. Would it be possible in some of the cases above to use type-instances to existing types (or to a reduced amount of new types) ? Thanks !
There was a problem hiding this comment.
Sure, I will refactor the code to use less types and and will update the PR soon :)
|
@mfournier, changes done :) Now uses a combination of plugin_instance and type_instance to avoid create a number of types in types.db, but "segments" one still necessary (I can't find another with similar meaning). |
The IPC module allows collectd to gather information about process IPC mechanims, like used semaphores, size of shared memory segments and so on...
Now the IPC plugin uses a combination of plugin_instance and type_instance to avoid creation of types.db. Just "segments" type is needed now.
| @@ -5158,6 +5158,7 @@ then | |||
| plugin_entropy="yes" | |||
| plugin_fscache="yes" | |||
| plugin_interface="yes" | |||
| plugin_ipc="yes" | |||
There was a problem hiding this comment.
As this plugin seems to also work in AIX, would you like to add it below (around line 5200) to build it by default on this platform ?
|
Globally I find this plugin nice and useful. Postgresql users will love it! 👍 for inclusion (barring the couple of open questions). Can someone else take a look please ? |
|
oops @ajdiaz I realize I didn't hilight you in my comments last week. Just wanted to make sure you've seen them. |
| @@ -2326,6 +2326,12 @@ other interfaces are collected. | |||
|
|
|||
| =back | |||
|
|
|||
| =head2 Plugin C<ipc> | |||
|
|
|||
| The I<IPC plugin> allows to B<collectd> to gather information about | |||
There was a problem hiding this comment.
Extra "to" - The IPC plugin allows collectd to gather...
|
Thanks a lot @ajdiaz ! The ipc plugin will be part of collectd 5.5. |
|
Thanks for the merge @mfournier, sorry to not reply before, I was on vacation without much internet access :) |
|
Thanks to you for your patience and for this nice plugin @ajdiaz :-) FYI the small changes I added on top of your patchet: cfe801c...a4cd2c3 I was also wondering if you'd care switching the licence to MIT (like most of the new plugins) ? |
|
@mfournier The changes are fine for me :) |
The IPC module allows collectd to gather information about process IPC
mechanims, like used semaphores, size of shared memory segments and so
on...
This is an old module which was missing during the big refactor waiting for
rebasing the current master. I hope that this new PR can be merged 😃