FreeBSD jail fixes #1019
FreeBSD jail fixes #1019
Conversation
|
Thanks a lot @biancalana ! I'm not too familiar with this, can you comment on the implications of changing the 2nd parameter to Also, I noticed the tcpconns plugin invokes |
| { | ||
| ERROR ("swap plugin: kvm_open failed."); | ||
| ERROR ("swap plugin: kvm_open failed, %s", errbuf); | ||
| return (-1); |
There was a problem hiding this comment.
Please change the message so it reads [...] kvm_openfiles [...]. Thanks !
- fix error msg on kvm_openfiles failure
|
Hi @mfournier ! I have based my changes on FreeBSD ps code, that use kvm_openfiles and works inside and outside jails... Also I have collectd with that changes working on FreeBSD with and without jails, but I can speak about other BSDs. I make additional changes as you requested. Regards, |
|
Great @biancalana, thanks ! I just pushed your patchset to the collectd-5.3 branch (the oldest relevant bugfix branch). It will eventually get merged to the more recent branches, and be part of the next bugfix & feature releases. I also realised meanwhile that the tcpconns plugin doesn't support the freebsd platform. The |
|
I'm using tcpconns plugin on FreeBSD and it works inside and outside Jails. As far as I can say it has always worked. 😂 Do you know when the next version will be released ? |
|
@biancalana by bad, it does indeed ! 😕 Thanks for checking, good to know all 3 of them work inside jails ! There's no fixed date for the next releases, although the next feature release (5.5) should get out pretty soon ! |
|
@mfournier do you plan to merge this fixes ? |
|
Actually I've seen that it was merged, but 5.5 changelog doesn't mention anything about fixes |
|
@biancalana yes, as it's actually a bugfix it will be part of the next relevant bugfix release. It's in the wiki page from which the changelog is generated at release time though: https://collectd.org/wiki/index.php/Version_5.3 This is a bit confusing admitedly :-/ |
Currently the process and swap plugins does not work inside Jail on FreeBSD, this patch fixes that.