-
Notifications
You must be signed in to change notification settings - Fork 1.2k
memcached_connections is of type GAUGE, needs to be submitted as a gauge. #1356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot @coreykosak ! I just want to be sure this is the right fix. According to fa91b25, this value is "a counter which increments when the connection limit to memcached is reached and a socket listen is disabled." If this is correct, submitting it as a derive is right, but the chosen data type is not. What do you think ? |
|
Thanks @coreykosak! Agreed, lines 438 and 442 contradict. If this is indeed a counter, another type has to be used. |
|
According to https://code.google.com/p/memcached/wiki/NewServerMaint and https://code.google.com/p/memcached/wiki/Timeouts, submit_derive ("connections", "listen_disabled", atof (fields[2]), st);
/* ^^^^^^^^^^^ */ |
Fixes: collectd#1356 (Cherry-pick of upstream commit 01e77b9)
Yes, choosen data type is incorrect. That is not 'connections', but a 'counter how many times limit was reached'. We are unable to know, how many connections was lost because of that. |
Put another way, line 442 needs to be consistent with line 438.
(credit: Jason Lawrence (https://github.com/chroniton) for finding this).