8000 Extend collected metrics in redis plugin by falzm · Pull Request #1483 · collectd/collectd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Extend collected metrics in redis plugin #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Extend collected metrics in redis plugin #1483

wants to merge 1 commit into from

Conversation

falzm
Copy link
Contributor
@falzm falzm commented Dec 22, 2015

This change adds support for other interesting Redis metrics:

  • expired_keys
  • keyspace_hits, keyspace_misses
  • total_net_input_bytes, total_net_output_bytes

It also fixes the DS type for expired_keys, which was incorrectly expressed as gauge instead of derive.

@falzm
Extend collected metrics in redis plugin
f89e52a 
This change adds support for other interesting Redis metrics:

* expired_keys
* keyspace_hits, keyspace_misses
* total_net_input_bytes, total_net_output_bytes

It also fixes the DS type for expired_keys, which was incorrectly
expressed as gauge instead of derive.
@haomingz
Copy link

+1

@mfournier mfournier modified the milestone: Features Jan 21, 2016
@falzm
Copy link
Contributor Author
falzm commented Feb 19, 2016

Hi, any feedback on this?

mfournier pushed a commit that referenced this pull request Feb 28, 2016
redis: change expired_keys type from GAUGE to DERIVE
d3f8bb5 
Thanks for @falzm for pointing this out in #1483 !
@mfournier
Copy link

Thanks a lot @falzm ! All good as far as I can tell.

I split your patch and merged it as a6ba92e and d3f8bb5.

@mfournier mfournier closed this Feb 28, 2016
@falzm
Copy link
Contributor Author
falzm commented Feb 28, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Features
Development

Successfully merging this pull request may close these issues.
3 participants
@falzm @haomingz @mfournier
0