nut plugin: Multi-threaded ups polling with connect timeout. #2354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @fragtion |
704eb56 to
1ef5c25
Compare
|
CC @Geraden07 |
1ef5c25 to
6bd2109
Compare
|
Wow, exceptional work man!! =D I will test this ASAP and revert back if any issues persist |
8000
|
Please revert back if NO issues persist, too. :-) |
5fe8ee6 to
40d8037
Compare
Changes: * Implemented use of 'plugin_register_complex_read', so querying will be multi-threaded; * Added 'ConnectTimeout' option, implemented with use of 'upscli_tryconnect()' added in nut-2.6.2; * The `upscli_cleanup()` should be called only at Collectd shutdown, excessive calls was removed; * Added `upscli_init()` call if `ForceSSL` enabled. * Added a check for duplicated values in `UPS` option. Closes: collectd#2344
40d8037 to
cb90ca8
Compare
|
Hi Ruben! Can you please review this PR and merge it if no other remarks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
The
upscli_connect()used before is a blocking function.upscli_cleanup()should be called only at Collectd shutdown, excessive calls was removed;upscli_init()call ifForceSSLenabled.UPSoption.Some useful notes:
Issue: #2344