apcups: allow to use plugin without explicit configuration #2351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the apcups plugin could not be used without defining an explicit configuration. While the apcups plugin did provide a localhost fallback, it did not however provide a 3551 port fallback in practice, eventhough a constant for that purpose was already present. Thanks to Pascal de Bruijn for report. Closes: collectd#2347
rubenk
reviewed
Jul 7, 2017
| void module_register(void) { | ||
| plugin_register_complex_config("apcups", apcups_config); | ||
| plugin_register_init("apcups", apcups_init); |
There was a problem hiding this comment.
I might miss something, but why don't you do this in apcups_config?
There was a problem hiding this comment.
The goal is to allow plugin use without defining an explicit configuration.
Then there in config file will be LoadPlugin apcups only, without <Plugin apcups> block.
The apcups_config() will not be called at all in that case.
There was a problem hiding this comment.
I see, thanks for the explanation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the apcups plugin could not be used without defining
an explicit configuration.
While the apcups plugin did provide a localhost fallback, it
did not however provide a 3551 port fallback in practice,
eventhough a constant for that purpose was already present.
Thanks to Pascal de Bruijn for report.
Supersedes: #2347