openldap: Fix crash on shutdown when openldap connection failed #2377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7722c51 to
2283208
Compare
When plugin failes to connect to LDAP server, the `ldap_unbind_ext_s(st->ld)` is called. According to `man 3 ldap_unbind_ext_s`, that call is used to free the resources contained in the ld structure. When plugin shutdown, the `ldap_unbind_ext_s` called again, which causes coredump. The plugin code was changed to set st->ld to NULL after `ldap_unbind_ext_s()` call.
2283208 to
ee2af3b
Compare
|
This change was checked in different conditions on my LDAP server, and it works perfectly. Let's merge it, please. |
|
Hi @rpv-tomsk, thanks, this looks much better now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When plugin failes to connect to LDAP server, the
ldap_unbind_ext_s(st->ld, NULL, NULL);is called.According to
man 3 ldap_unbind_ext_s(https://linux.die.net/man/3/ldap_unbind_ext_s), that call is used to unbind from the directory, terminate the current association, and free the resources contained in the ld structure.When plugin shutdown, the
ldap_unbind_ext_scalled again, which causes coredump.The plugin code was changed to set
st->ld=NULLafterldap_unbind_ext_scall.No more coredumps.