8000 memcached plugin: Report "listen_disabled_num" as "total_events". by octo · Pull Request #2468 · collectd/collectd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

memcached plugin: Report "listen_disabled_num" as "total_events". #2468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2017
Merged

memcached plugin: Report "listen_disabled_num" as "total_events". #2468

merged 2 commits into from
Oct 24, 2017

Conversation

octo
Copy link
Member
@octo octo commented Oct 6, 2017

Fixes: #2386

@octo octo added the Bug A genuine bug label Oct 6, 2017
@rpv-tomsk
Copy link
Contributor

As per https://github.com/memcached/memcached/blob/master/doc/protocol.txt#L681, the source field of this metric represents a 'Number of times server has stopped accepting new connections'.
This is not a number of operations, but a number of events.
Unfortunately, Collectd now has no such type as events, so I can't propose the type to use.

@octo
Copy link
Member Author
octo commented Oct 6, 2017

"listen [was] disabled" sounds like an operation that was performed, not an event that just happened, but I know nothing about memcached, so I might be way off here ;-)

@rpv-tomsk rpv-tomsk added this to the 5.8 milestone Oct 18, 2017
@rpv-tomsk
Copy link
Contributor

What would we do this this?
Proposals: events_rate (new common type to be added).

@octo octo force-pushed the ff/memcached branch 3 times, most recently from c3dcd63 to d18296b Compare October 23, 2017 19:19
@octo octo added the Automerge Labels PRs to be merged by a bot once approved label Oct 23, 2017
@rpv-tomsk rpv-tomsk merged commit 7de394e into collectd:master Oct 24, 2017
@rpv-tomsk
Copy link
Contributor

[Auto]Merged. ;-)

Thanks for a work!

@rpv-tomsk rpv-tomsk changed the title memcached plugin: Report "listen_disabled_num" as "operations". memcached plugin: Report "listen_disabled_num" as "total_events". Oct 24, 2017
@octo octo deleted the ff/memcached branch October 25, 2017 05:50
@octo octo added Fix A pull request fixing a bug and removed Bug A genuine bug labels Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Automerge Labels PRs to be merged by a bot once approved Fix A pull request fixing a bug
Projects
None yet
Milestone
5.8
Development

Successfully merging this pull request may close these issues.
2 participants
@octo @rpv-tomsk
0