Open
Description
CC: @rubenk, @rpv-tomsk, @tokkee
Hi team,
as you may be aware, the Automerge label will cause @collectd-bot to automatically merge pull requests when certain conditions are met (CI succeeds, no pending reviews, …). I'm thinking about changing the behavior a bit and would like your thoughts on this:
- Require one "approved" review from one of the maintainers instead of the
Automergelabel. I.e. as soon as a maintainer approves a change, it will automatically get merged (assuming CI is successful). - As a second step, I'd like to integrate with Github's code ownership concept. When, for example, a pull request only touches
src/dpdk{events,stat}.c, then a (positive) review from one of the Intel folks working on this should be sufficient to trigger the merge. We should encourage contributors to add themselves as owners of new plugins.
Caveats:
- You can now "resolve" code review comments in the UI, but as far as I see it's not possible to distinguish "resolved" from "unresolved" comments in the API. That means you'd have to ensure all comments are fixed before approving.
- It's unclear how much of the code ownership we have to implement ourselves. I'm hoping that with the "Require review from Code Owner" option enabled a PR is simply marked as "not mergable" unless the condition is met. But the API docs are extremely vague with details like this.
What do you think?
Best regards,
—octo