MQTT: Resubscribe after a reconnect #3452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-format issues are outside the code parts affected by this change so they won't fit this PR very well. |
octo
reviewed
May 1, 2020
Just put those cosmetic fixes in a separate commit – the check doesn't negotiate ;) |
|
Thanks for your quick review Florian, will add a comment fixing the clang-format reported things in a respin. |
octo
reviewed
May 2, 2020
After losing our connection to a MQTT broker our subscription will be gone, too, so we need to subscribe to our topic once again after reconnecting, otherwise collectd will not receive any MQTT messages anymore. Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
This is an automated code style fix generated by running "contrib/format.sh src/mqtt.c". No functional change intended. Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After losing our connection to a MQTT broker our subscription will be gone, too, so we need to subscribe to our topic once again after reconnecting, otherwise collectd will not receive any MQTT messages any more.
ChangeLog: MQTT plugin: Resubscribe after a reconnect
Fixes: #3442