Add a Count option to snmp plugin #3504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a Count option to the snmp plugin allowing to gather the number of table entries (matching given criteria) rather than their values. This is especially useful in combination with the recently introduced Filter options. Example: Count number of total/connected stations on a (Lancom) Access Point. Indentation changes to existing code are deferred to the next commit in order ease review.
Mechanical indentation changes intentionally exempted from the last commit (to facilitate review).
Allow the value to be of an type other than DS_COUNTER when using the Count option. I'm sure this can be done more elgantly.
mrunge
reviewed
Jul 17, 2020
|
I have a small nit.
Which is?
|
|
@octo dropped absolute counters
But that's in the collectd-6.0 branch, no?
In main, I'll need to cope with someone requesting DS_TYPE_ABSOLUTE.
|
|
yes, that's correct, that's in 6.0. So, for 6.0 there is some change required. |
|
So, for 6.0 there is some change required.
So what am I expected to do? Create a second Pull Request for collectd-6?
I guess it would be far easier to make that trivial change within a merge to -6 once my branch has been merged, no?
|
|
I'd update the PR and drop DS_TYPE_ABSOLUTE right now. We removed it, since it was not widely used, if it was used at all. Anyways, that can be done in another PR, I'm good with mer 86D2 ging this here. |
mrunge
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChangeLog: A count option was added allowing to gather the number of table entries (matching given criteria) rather than their values.
Add a
Countoption to the snmp plugin allowing to gather the number of table entries (matching given criteria) rather than their values.This is especially useful in combination with the recently introduced Filter options.
Example: Count number of total/connected stations on a (Lancom) Access Point.