8000 capabilities: conditionalize mhd callback return type by pvxe · Pull Request #3512 · collectd/collectd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

capabilities: conditionalize mhd callback return type #3512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2020
Merged

capabilities: conditionalize mhd callback return type #3512

merged 2 commits into from
Jul 22, 2020

Conversation

pvxe
Copy link
Contributor
@pvxe pvxe commented Jul 18, 2020

Fixes #3511

ChangeLog: Conditionalize return type for microhttpd callback functions

@pvxe
capabilities: conditionalize mhd callback return type
7a336c2 
libmicrohttpd introduced an API change with respect its callback
return types. Now its signature says that an enum must be returned
instead of an int. This causes collectd to not finish compilation
because of the compiler warnings this arised (in addition to -Werror)

Add conditional compiling so systems with microhttpd >=0.9.71 can
compile collectd with -Werror

Fixes collectd#3511
@pvxe pvxe requested a review from a team as a code owner July 18, 2020 10:43
kwiatrox
kwiatrox approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member
@kwiatrox kwiatrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for updating this.

@mrunge mrunge merged commit 52fa1be into collectd:main Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunge mrunge mrunge approved these changes

@kwiatrox kwiatrox kwiatrox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libmicrohttpd API change in 0.9.71
3 participants
@pvxe @mrunge @kwiatrox
0