8000 Missing dependency in setup.py · Issue #118 · commaai/laika · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Missing dependency in setup.py #118
Open
@jmccartin

Description

@jmccartin

This is a pretty simple issue at first glance.

You have a missing dependency in setup.py for the library atomicwrites. The actual library c 5A29 alls are in downloader.py, for example:

with atomic_write(filepath_attempt, mode='w', overwrite=True) as wf:

This means that any project that uses laika as a dependency itself will fail unless it explicitly knows to install atomicwrites itself. But on the project homepage, the author of that package recommends its deprecation:

I thought it'd be a good time to deprecate this package. Python 3 has os.replace and os.rename which probably do well enough of a job for most usecases.

So, what's the need for that atomic_write function? Could it not be simply replaced by a basic wrapper using native library calls?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0