8000 Improve experience for integrators · Issue #40 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve experience for integrators #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
3 of 13 tasks
sergio-mena opened this issue Dec 23, 2022 · 0 comments
Open
3 of 13 tasks

Improve experience for integrators #40

sergio-mena opened this issue Dec 23, 2022 · 0 comments
Labels
major-priority A major, long-running priority for the team P:integrator-experience Priority: Improve experience for integrators

Comments

@sergio-mena
Copy link
Contributor
sergio-mena commented Dec 23, 2022 •
edited by adizere
Loading

High-level tracking issue for improvements targeting users who want to integrate with CometBFT-based nodes. This issue will be expanded over time.

Integrators currently make use of several surfaces/APIs of a CometBFT-based node in order to provide value-added services on top of those nodes. We want to provide ways to make integrators' lives easier.

This issue does not cover the Go APIs. For improvements targeting the Go APIs, please see #42

Sub-issues:

Original issue tendermint/tendermint#9883
@thanethomson thanethomson added major-priority A major, long-running priority for the team P:integrator-experience Priority: Improve experience for integrators labels Dec 23, 2022
@thanethomson thanethomson moved this to Todo in CometBFT 2023 Jan 21, 2023
@thanethomson thanethomson changed the title Improvements for integrators Improve experience for integrators Mar 27, 2023
cometcrafter pushed a commit to graphprotocol/cometbft that referenced this issue May 13, 2024
@mergify @czarcas7ic
perf(p2p/channel): Speedup NewDelimitedWriter (backport cometbft#2949) (
e3a14f0 
cometbft#2969) (cometbft#40) (cometbft#49)

Speeds up 5% of the non-IO time overhead from
`channel.WritePacketMsgTo`. The CPU time overhead in this function is
quite significant, CPU time is more than 3 times the syscall time for
writing to the net buffer. Working on a github issue for more
substantial refactor / time eliminations, but this 3s is easy enough.

We don't even use this codepath, so this make slice is entirely wasted.
However we should do things that reduce this overhead further.

![image](https://github.com/cometbft/cometbft/assets/6440154/e02e45bf-d6ff-4e11-9983-e81ca1102dc8)

---

#### PR checklist

- [x] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [x] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
<hr>This is an automatic backport of pull request cometbft#2949 done by
[Mergify](https://mergify.com).

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
(cherry picked from commit 3d1b9dc)

Co-authored-by: Adam Tucker <adam@osmosis.team>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-priority A major, long-running priority for the team P:integrator-experience Priority: Improve experience for integrators
Projects
No open projects
CometBFT 2023
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thanethomson @sergio-mena
0