8000 mempool/lanes: Validate that app versions match on P2P handshake · Issue #4043 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

mempool/lanes: Validate that app versions match on P2P handshake #4043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #2803
hvanz opened this issue Sep 9, 2024 · 2 comments
Closed
Tracked by #2803

mempool/lanes: Validate that app versions match on P2P handshake #4043

hvanz opened this issue Sep 9, 2024 · 2 comments
Labels
mempool
Milestone
2024-Q3

Comments

@hvanz
Copy link
Member
hvanz commented Sep 9, 2024

From the ADR:

Different nodes also need to agree on the lanes they use. When a node connects to a peer, they both
perform a handshake to agree on some basic information (see DefaultNodeInfo). Since the
application includes the lane definitions, it suffices to ensure that both nodes agree on the
version of the application. Although the application version is included in DefaultNodeInfo, there
is currently no check for compatibility between the versions. To address this, we would need to
modify the P2P handshake process to validate that the application versions are compatible.
@hvanz hvanz added the mempool label Sep 9, 2024
@hvanz hvanz added this to CometBFT Sep 9, 2024
@github-project-automation github-project-automation bot moved this to Todo in CometBFT Sep 9, 2024
@hvanz hvanz mentioned this issue Sep 12, 2024
Closed
42 tasks
@hvanz hvanz added this to the 2024-Q3 milestone Sep 18, 2024
@jmalicevic
Copy link
Contributor

This will not go into the MVP, right? Should we mark it as such somehow?

@hvanz
Copy link
Member Author
hvanz commented Sep 20, 2024

Right, we don't want to put a restriction on which app version the nodes must have. We will allow different app versions in the network, even if we know that transactions will not be disseminated and reaped in the same way as if all the nodes use the same app version.

Closing this issue as we won't implement this requirement.

@hvanz hvanz closed this as not planned Won't fix, can't repro, duplicate, stale Sep 20, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in CometBFT Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mempool
Projects
No open projects
CometBFT
Status: Done
Milestone
2024-Q3
Development

No branches or pull requests

2F0F
2 participants
@jmalicevic @hvanz
0