8000 Deprecate blocksync-related configuration in `v0.37.x` that disables blocksync. Remove it from `v0.38.x` · Issue #409 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Deprecate blocksync-related configuration in v0.37.x that disables blocksync. Remove it from v0.38.x #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
sergio-mena opened this issue Feb 28, 2023 · 0 comments
Closed
2 tasks done

Deprecate blocksync-related configuration in v0.37.x that disables blocksync. Remove it from v0.38.x #409

sergio-mena opened this issue Feb 28, 2023 · 0 comments
Assignees
@hvanz
Labels
block-sync breaking A breaking change config

Comments

@sergio-mena
Copy link
Contributor
sergio-mena commented Feb 28, 2023 •
edited by hvanz
Loading

Tracked by: #41 and #10

After some discussion on two alternatives on how to tackle an error path with vote extensions in v0.38.x, the CometBFT decided to remove the possibility for blocksync to be configurable (it must always be active).

Therefore:

DoD

  • There is an (early) release of v0.37.x that warns the operator with a deprecation message if they configure their node to disable blocksync
  • It is not possible for the operator to disable blocksync in v0.38.x
@sergio-mena sergio-mena added enhancement New feature or request needs-triage This issue/PR has not yet been triaged by the team. config block-sync breaking A breaking change and removed enhancement New feature or request needs-triage This issue/PR has not yet been triaged by the team. labels Feb 28, 2023
This was referenced Feb 28, 2023
Closed
Closed
@hvanz hvanz self-assigned this Feb 28, 2023
This was referenced Feb 28, 2023
Merged
Merged
@hvanz hvanz moved this from Todo to Done in CometBFT 2023 Mar 6, 2023
@hvanz hvanz closed this as completed Mar 6, 2023
@conorsch conorsch mentioned this issue Oct 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hvanz hvanz

Labels
block-sync breaking A breaking change config
Projects
No open projects
CometBFT 2023
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sergio-mena @hvanz
0