e2e: application should log when a transaction is evicted from the mempool

The e2e application has a logic to evict transactions from the mempool after a given amount of heights, if they are still present there. If it is part of the re-check tx logic:

cometbft/test/e2e/app/app.go

Lines 281 to 287 in 276996a

    
           if stHeight > txHeight.(uint64)+txTTL { 
        
           	app.logger.Debug("Application CheckTx", "msg", "transaction expired", "tx_hash", cmttypes.Tx.Hash(req.Tx), "seen_height", txHeight, "current_height", stHeight) 
        
           	app.seenTxs.Delete(txKey) 
        
           	return &abci.CheckTxResponse{ 
        
           		Code: kvstore.CodeTypeExpired, 
        
           		Log:  fmt.Sprintf("transaction expired; seen height %v, current height %v", txHeight, stHeight), 
        
           	}, nil

This information, when a transaction is evicted, is logged in Debug mode, therefore not seen during ordinary executions.

I suggest that this information should be always visible, therefore logged in Info mode.

By the way, how can we set the debug level for the e2e application?

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if stHeight > txHeight.(uint64)+txTTL {
	app.logger.Debug("Application CheckTx", "msg", "transaction expired", "tx_hash", cmttypes.Tx.Hash(req.Tx), "seen_height", txHeight, "current_height", stHeight)
	app.seenTxs.Delete(txKey)
	return &abci.CheckTxResponse{
	Code: kvstore.CodeTypeExpired,
	Log: fmt.Sprintf("transaction expired; seen height %v, current height %v", txHeight, stHeight),
	}, nil

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions