8000 Implement same-block execution mode · Issue #446 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Implement same-block execution mode #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Tracked by #9
adizere opened this issue Mar 2, 2023 · 0 comments
Open
Tracked by #9

Implement same-block execution mode #446

adizere opened this issue Mar 2, 2023 · 0 comments
Labels
abci Application blockchain interface enhancement New feature or request P:new-use-cases Priority: Enable new use cases for application developers

Comments

@adizere
Copy link
Member
adizere commented Mar 2, 2023 •
edited by sergio-mena
Loading

Summary

ABCI++, as of ABCI 2.0 (shipped in the first release after v0.38.x), does not support same-block execution mode.

Problem Definition

The ABCI++ spec living in master contains the full specification of this mode, also with the additional fields needed in ResponsePrepareProposal.

Proposal

We need to:

  • add (back) the extra fields in ResponsePrepareProposal's protobuf
  • Add a parameter (a boolean)same-block-mode in the Genesis block, or config.toml
  • implement the dual logic: depending on the boolean, we
    • read the relevant values from ResponseFinalizeBlock or from ResponsePrepareProposal
    • set those values (a) in the block after the one just decided, or (n) in the block about to be proposed
    • Adapt light client, block sync, and any other mechanism that navigates the blockchain data

Was originally: tendermint/tendermint#8233
@adizere adizere added enhancement New feature or request needs-triage This issue/PR has not yet been triaged by the team. labels Mar 2, 2023
@adizere adizere mentioned this issue Mar 2, 2023
Open
27 tasks
@adizere adizere added abci Application blockchain interface and removed needs-triage This issue/PR has not yet been triaged by the team. labels Mar 2, 2023
@adizere adizere added the community-call To be discussed in an upcoming community call label Mar 7, 2023
@sergio-mena sergio-mena mentioned this issue Mar 30, 2023
Closed
@thanethomson thanethomson added P:new-use-cases Priority: Enable new use cases for application developers and removed community-call To be discussed in an upcoming community call labels Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
abci Application blockchain interface enhancement New feature or request P:new-use-cases Priority: Enable new use cases for application developers
Projects
No open projects
CometBFT 2023
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thanethomson @adizere
0