8000 e2e(main): Tests failing due to validator oscillation · Issue #4492 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

e2e(main): Tests failing due to validator oscillation #4492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Tracked by #2458
jmalicevic opened this issue Nov 15, 2024 · 0 comments
Open
Tracked by #2458

e2e(main): Tests failing due to validator oscillation #4492

jmalicevic opened this issue Nov 15, 2024 · 0 comments
Assignees
@jmalicevic
Labels
bug Something isn't working e2e Related to our end-to-end tests
Milestone
2024-Q4

Comments

@jmalicevic
Copy link
Contributor
jmalicevic commented Nov 15, 2024 •
edited by cason
Loading

PR #2283 introduced validator and consensus parameter oscillation in our e2e infrastructure (this is part of #2458) . However, at the moment the validator oscillations cause the nightly's to fail on main . Most likely due to corner case tests that need to be fixed.

We will temporary disable this feature to reduce the noise in testing, see #4478.

This has to be followed up with properly fixing the tests so that the oscillations work. See comments added to #4478.

Quoting @cason:

The problem is that the updates produced by the generator (which are more relevant changes) might conflict with the validator updates produced by the oscillation logic (which just turn on and off a validator, with voting power 1 and 0). The latter has to be fixed.
@jmalicevic jmalicevic added bug Something isn't working e2e Related to our end-to-end tests labels Nov 15, 2024
@jmalicevic jmalicevic added this to the 2024-Q4 milestone Nov 15, 2024
@github-project-automation github-project-automation bot moved this to Todo in CometBFT Nov 15, 2024
@jmalicevic jmalicevic mentioned this issue Nov 15, 2024
Merged
3 tasks
@cason cason mentioned this issue Nov 15, 2024
Open
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Nov 15, 2024
@cason @andynog @mergify
fix(e2e): temporary disable validator set oscillation in generated ma…
c6fa225 
…nifests (#4478)

Workaround for #4492.

This PR:

1. Describes the issue with introduced by
#2283 in comments in the source
code (check FIXMEs and TODOs)
2. Temporarily disables the validator set oscillations in the generated
manifest, used in nightly runs

Item 2. has the side effect that not only the validator set oscillations
but also the consensus params oscillations are disabled, while we are
only aware of issues in the former.

---

#### PR checklist

- [ ] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments

---------

Co-authored-by: Andy Nogueira <me@andynogueira.dev>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@jmalicevic jmalicevic self-assigned this Dec 13, 2024
@jmalicevic jmalicevic moved this from Todo to In Progress in CometBFT Dec 13, 2024
@jmalicevic jmalicevic mentioned this issue Dec 13, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmalicevic jmalicevic

Labels
bug Something isn't working e2e Related to our end-to-end tests
Projects
No open projects
CometBFT
Status: In Progress
Milestone
2024-Q4
Development

Successfully merging a pull request may close this issue.

fix(e2e): Improve the validator oscillation logic cometbft/cometbft
1 participant
@jmalicevic
0