8000 feat(mempool/dog): Optimize sending of `ResetRoute` · Issue #4617 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(mempool/dog): Optimize sending of ResetRoute #4617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jmalicevic opened this issue Dec 6, 2024 · 1 comment
Open

feat(mempool/dog): Optimize sending of ResetRoute #4617

jmalicevic opened this issue Dec 6, 2024 · 1 comment
Labels
mempool protocol-change A protocol change proposal

Comments

@jmalicevic
Copy link
Contributor
jmalicevic commented Dec 6, 2024 •
edited
Loading

DOG Protocol Change Proposal

When transaction redundancy in a node is too low (too few duplicates), a node is potentially open for attacks. When the redundancy controller of the protocol notices this, it triggers sending a ResetRoute message to a random peer of the node. This peer will then remove the node from any of its DisabledRoute lists and allow future traffic to flow unrestricted to the node. Routes are disabled when a node sends a HaveTx message to this peer.

Currently the choice of the peer to whom a ResetRoute message is sent is random. That means that a node can, in theory, send a ResetRoute message to a peer that has not previously received a HaveTx message, because the protocol does not keep information about to whom a HaveTx message has been sent.

At the moment this did not have any negative effects but it could mean a node takes more time to catch up on transactions.

We propose an optimization to the protocol, whereby a node remembers to whom HaveTx messages have been sent and only send a ResetRoute message to those peers.

cc @hvanz
@jmalicevic jmalicevic added mempool protocol-change A protocol change proposal labels Dec 6, 2024
@github-project-automation github-project-automation bot moved this to Todo in CometBFT Dec 6, 2024
@najeal
Copy link
Contributor
najeal commented Jan 2, 2025

Can I pick this one?

@najeal najeal mentioned this issue Jan 3, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mempool protocol-change A protocol change proposal
Projects
No open projects
CometBFT
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(mempool/dog): optimize sending of ResetRoute najeal/cometbft
2 participants
@jmalicevic @najeal
0