8000 Backport "Allow Privval to sign arbitrary bytes" to v1 · Issue #5134 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Backport "Allow Privval to sign arbitrary bytes" to v1 #5134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zrbecker opened this issue May 20, 2025 · 2 comments
Open

Backport "Allow Privval to sign arbitrary bytes" to v1 #5134

zrbecker opened this issue May 20, 2025 · 2 comments
Labels
enhancement New feature or request needs-triage This issue/PR has not yet been triaged by the team.

Comments

@zrbecker
Copy link
Contributor

Feature Request

Summary

We want to backport this to v1.

  • [privval] Allow Privval to sign arbitrary bytes (#2692)

However, adding a method to this public interface is technically a breaking change as any implementor of that interface would need to add the method.

We should establish if this interface should be exposed as part of the types package, and if so, consider creating a new interface with the additional field to support usage of implementations that implement this new functionality.

Problem Definition

Proposal
@zrbecker zrbecker added enhancement New feature or request needs-triage This issue/PR has not yet been triaged by the team. labels May 20, 2025
@linear Linear
Copy link
linear bot commented May 20, 2025

COMET-299 Backport "Allow Privval to sign arbitrary bytes" to v1

@rach-id
Copy link
rach-id commented May 21, 2025

is this part of #5126? We would love to also add the chainID to the requests when backporting and also we could make the change on v1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request needs-triage This issue/PR has not yet been triaged by the team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zrbecker @rach-id
0