10000 RPC server: Long Log Messages · Issue #654 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

RPC server: Long Log Messages #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task
Tracked by #54
gaia opened this issue Apr 5, 2023 · 3 comments · Fixed by #829
Closed
1 task
Tracked by #54

RPC server: Long Log Messages #654

gaia opened this issue Apr 5, 2023 · 3 comments · Fixed by #829
Assignees
@thanethomson
Labels
enhancement New feature or request good first issue Good for newcomers logs Anything relating to logging
Milestone
2023-Q2

Comments

@gaia
Copy link
gaia commented Apr 5, 2023 •
edited by adizere
Loading

Feature Request

Summary

Syslog has trouble handling these long strings (see below). Not sure if they are even needed in logs, but it would surely be great to be able to suppress them, even if syslog gets adjusted to handle them (max message size), just to spare disk IO and reduce log size.

Problem Definition

https://paste2.org/xbEIvUhb

Acceptance criteria

  • truncate the log output in the example above
    • decide if the txs raw bytes are useful in the log in the first place (most likely not useful)
      • if useful: keep a truncated version;
      • if not useful: remove the txs bytes entirely from the log output
@gaia gaia added enhancement New feature or request needs-triage This issue/PR has not yet been triaged by the team. labels Apr 5, 2023
@adizere adizere added good first issue Good for newcomers logs Anything relating to logging and removed needs-triage This issue/PR has not yet been triaged by the team. labels Apr 27, 2023
@adizere
Copy link
Member
adizere commented Apr 27, 2023

Excellent feedback, thanks for logging the issue @gaia !

Will track this under #54, looks like a relatively low-hanging fruit.

@adizere adizere changed the title Long Log Messages RPC server: Long Log Messages Apr 27, 2023
@adizere adizere mentioned this issue Apr 27, 2023
Open
28 tasks
@thanethomson
Copy link
Contributor

What's a good maximum log length here?

@thanethomson thanethomson self-assigned this May 12, 2023
@thanethomson thanethomson moved this from Todo to In Progress in CometBFT 2023 May 12, 2023
@thanethomson thanethomson added this to the 2023-Q2 milestone May 12, 2023
@thanethomson thanethomson mentioned this issue May 12, 2023
Merged
3 tasks
@gaia
Copy link
Author
gaia commented May 14, 2023

What's a good maximum log length here?

See #829 (comment)

@github-project-automation github-project-automation bot moved this from In Progress to Done in CometBFT 2023 May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thanethomson thanethomson

Labels
enhancement New feature or request good first issue Good for newcomers logs Anything relating to logging
Projects
No open projects
CometBFT 2023
Status: Done
Milestone
2023-Q2
Development

Successfully merging a pull request may close this issue.

rpc: Remove response data from response failure logs cometbft/cometbft
3 participants
@gaia @thanethomson @adizere
0