8000 ADR-101: Backport to `v0.37.x` · Issue #1420 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ADR-101: Backport to v0.37.x #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
5 of 18 tasks
Tracked by #574
jmalicevic opened this issue Oct 2, 2023 · 2 comments
Closed
5 of 18 tasks
Tracked by #574

ADR-101: Backport to v0.37.x #1420

jmalicevic opened this issue Oct 2, 2023 · 2 comments
Labels
grpc Anything relating to the gRPC API P:storage-optimization Priority: Give operators greater control over storage and storage optimization tracking A complex issue broken down into sub-problems
Milestone
2024-Q1

Comments

@jmalicevic
Copy link
Contributor
jmalicevic commented Oct 2, 2023 •
edited by adizere
Loading

This issue covers all the tasks needed to backport the implementation of ADR-101 from main into v0.38.x.

We will backport this feature into an experimental branch because :

  • We have to break existing go API interfaces and v0.37.x is already released
  • The pruning mechanism is happening in the background now, instead of synchronously between heights which changes the existing logic.

The ADR will be backported step by step, porting one big feature at a time.

Fixes related to pruning done in main and on v0.38.x:

Some of those (especially the e2e related ones) might not be needed in 0.37.x but that needs to be confirmed in case of a backport of ADR 101 to 0.37.x-experimental

Backporting the pruning mechanisms is independent of the gRPC backports and can be done in parallel. The pruning service endpoints depend on the pruning mechanisms being implemented.
@jmalicevic jmalicevic mentioned this issue Oct 2, 2023
Closed
5 tasks
@jmalicevic jmalicevic added tracking A complex issue broken down into sub-problems grpc Anything relating to the gRPC API P:storage-optimization Priority: Give operators greater control over storage and storage optimization labels Oct 2, 2023
@cason cason mentioned this issue Oct 6, 2023
Closed
8000 3 tasks
@cason cason moved this from Todo to In Progress in CometBFT 2023 Oct 6, 2023
@cason cason modified the milestone: 2023-Q4 Oct 6, 2023
@cason cason mentioned this issue Oct 6, 2023
Closed
4 tasks
@cason cason moved this from In Progress to Todo in CometBFT 2023 Oct 10, 2023
@cason
Copy link
Contributor
cason commented Oct 10, 2023

We are temporarily stopping the efforts on this backport effort, in order to focus first on the backport of the same features to v0.38.x-experimental (#1419).

@adizere adizere added this to the 2024-Q1 milestone Jan 11, 2024
@adizere adizere added this to CometBFT Jan 11, 2024
@github-project-automation github-project-automation bot moved this to Todo in CometBFT Jan 11, 2024
@adizere adizere moved this from Todo to Done in CometBFT Jan 11, 2024
@adizere
Copy link
Member
adizere commented Jan 11, 2024

Closing. No clear signals that it's needed from users.

@adizere adizere closed this as completed Jan 11, 2024
@adizere adizere mentioned this issue Apr 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
grpc Anything relating to the gRPC API P:storage-optimization Priority: Give operators greater control over storage and storage optimization tracking A complex issue broken down into sub-problems
Projects
No open projects
CometBFT
Status: Done
CometBFT 2023
Status: Todo
Milestone
2024-Q1
Development

No branches or pull requests
4 participants
@cason @adizere @jmalicevic @hvanz
0