8000 Refactor or add new unit tests to use exported errors · Issue #2660 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactor or add new unit tests to use exported errors #2660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Tracked by #1140
andynog opened this issue Mar 19, 2024 · 0 comments
Open
Tracked by #1140

Refactor or add new unit tests to use exported errors #2660

andynog opened this issue Mar 19, 2024 · 0 comments
Labels
enhancement New feature or request testing related to unit testing in general

Comments

@andynog
Copy link
Contributor
andynog commented Mar 19, 2024

Summary

Refactor or add new unit tests to use exported errors

Problem Definition

There is no consistency in using exported errors (#1140) throughout the internal modules. Exported errors should be used in the unit tests.

Proposal

After issue #1140 is resolved, we should make use of all the exported errors in our unit tests to enhance the testing process. Currently, several unit tests depend on logic to compare generic errors and not specific errors. However, with the creation of exported errors, we can start comparing specific errors as well. This could also be an excellent chance to introduce new unit tests using the newly exported errors.

DoD
@andynog andynog added enhancement New feature or request testing related to unit testing in general labels Mar 19, 2024
@andynog andynog added this to CometBFT Mar 19, 2024
@github-project-automation github-project-automation bot moved this to Todo in CometBFT Mar 19, 2024
@andynog andynog mentioned this issue Mar 19, 2024
Open
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request testing related to unit testing in general
Projects
No open projects
CometBFT
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andynog
0