Open
Description
If you checkout main
git checkout main
then If you use a manifest such as to run e2e:
[node.validator]
version = "cometbft/e2e-node:v1.x"
When running the e2e test, it errors out with:
I[2024-08-26|18:00:47.891] Running all tests in ./tests/...
--- FAIL: TestGRPC_Version (0.00s)
--- FAIL: TestGRPC_Version/validator (0.00s)
e2e_test.go:95:
Error Trace: /Go/src/github.com/cometbft/cometbft/test/e2e/tests/grpc_test.go:33
/Go/src/github.com/cometbft/cometbft/test/e2e/tests/e2e_test.go:95
Error: Not equal:
expected: "1.0.0-dev"
actual : "1.0.0-rc1"
Diff:
--- Expected
+++ Actual
@@ -1 +1 @@
-1.0.0-dev
+1.0.0-rc1
Test: TestGRPC_Version/validator
FAIL
FAIL github.com/cometbft/cometbft/test/e2e/tests 4.114s
FAIL
The root cause is the difference between the CMTSemVer in version.go between the main and v1.x branch
On main:
package version
const (
// CMTSemVer is used as the fallback version of CometBFT
// when not using git describe. It uses semantic versioning format.
CMTSemVer = "1.0.0-dev"
On v1.x
package version
const (
// CMTSemVer is the used as the fallback version of CometBFT
// when not using git describe. It is formatted with semantic versioning.
CMTSemVer = "1.0.0-rc1"
The version.go files needs to be updated on main to match the one in v1.x.