8000 Notes are overwritten upon "Auto-Tag" even with "Overwrite metadata" unchecked · Issue #390 · comictagger/comictagger · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Notes are overwritten upon "Auto-Tag" even with "Overwrite metadata" unchecked #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ducky0518 opened this issue Nov 4, 2022 · 8 comments
Closed

Notes are overwritten upon "Auto-Tag" even with "Overwrite metadata" unchecked #390

ducky0518 opened this issue Nov 4, 2022 · 8 comments

Comments

@ducky0518
Copy link

Hello I'm using the current v1.5.4

I have a .cbz file that already has some fields filed in (like notes). I'm expecting for Comictagger to append (add) to the notes section with the banner and issueID, but it appears it completely overwrites whats in there even though the "Overwrite metadata" box is unchecked which comes up when you start the auto tagging process.

Should be relatively easy to reproduce. Let me know if any questions. Thanks!
@lordwelch
Copy link
Member

The "Overwrite metadata" checkbox clears all metadata before applying metadata from ComicVIne, it might make sense to rename that particular option. Currently when metadata is applied it will copy any non-empty metadata, the notes section would always be set and so would always replace whatever already in it.

@ducky0518
Copy link
Author
ducky0518 commented Nov 4, 2022 •
edited
Loading

So, how do I keep what's in the notes section already without it being overwritten?

Also, you say "it will copy any non-empty metadata" - and do what with it?

@lordwelch
Copy link
Member

So, how do I keep what's in the notes section already without it being overwritten?

ComicTagger doesn't have a way to preserve it right now. I'm looking to see what other metadata might have a reason to be preserved, obviously with the notes being entirely generated by ComicTagger it makes sense to provide an option preserve any notes that already exist. I probably won't make it append to the notes as I would have to check if it was already there and that can quickly get out of hand, I will probably just make it so the notes is only set if it is empty.

Also, you say "it will copy any non-empty metadata" - and do what with it?

In other words:
comic1.cbz(notes='This is a note', title='this is a title') <- ComicVine(notes='<by ComicTagger>', title='')
becomes
comic1.cbz(notes='<generated by ComicTagger>', title='this is a title')

if you have the "Overwrite metadata" box checked:
comic1.cbz(notes='This is a note', title='this is a title') <- ComicVine(notes='<by ComicTagger>', title='')
becomes
comic1.cbz(notes='<generated by ComicTagger>', title='')

@ducky0518
Copy link
Author
ducky0518 commented Nov 4, 2022 •
edited
Loading

Basically let me explain. I have ComicRack setting things like an original filename and filepath and saving that to the notes section.
I then had been using the CV Scraper as part of ComicRack - but your image matching algorithm is awesome and I have more faith in that correctly matching. The issue, however, is that Mylar expects the IssueID to be at the very end of the notes section. (it looks for it in brackets at the end) - So if I want to keep my original filename info AND add have the issueID at the end - and ideally use ComicTagger to do the matching since it does it so well (it also does better scan info detection and capture). Does this make sense? Let me know your thoughts.

@lordwelch
Copy link
Member

Definitely don't want to break mylar, I've never used it my self but it uses an old embedded version of ComicTagger.
I might be able to come up with something this weekend.

@ducky0518
Copy link
Author

That would be very much appreciated. I'm willing to contribute funds if that would help! Let me know how I can get something to you, if that would help. Again, just looking for it to append the ComicTagger notes to the original notes that are already there. Thanks.

@lordwelch
Copy link
Member

I just pushed som commits to address this, you can download a package from master here (scroll all the way to the bottom) to test.

@ducky0518
Copy link
Author

OMG - This worked - PERFECT! For real, I'm willing to pay for your efforts. This is BEYOND appreciated. Is there a patreon/paypal/bitcoin address, anything? It may not have been much effort for you but saves me literally hundreds of hours manually tagging

@lordwelch lordwelch mentioned this issue May 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lordwelch @ducky0518
0