8000 Onboarding uses wrong filename "get-started" vs "start" · Issue #342 · configu/configu · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Onboarding uses wrong filename "get-started" vs "start" #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mdp opened this issue Jan 16, 2024 · 2 comments
Closed

Onboarding uses wrong filename "get-started" vs "start" #342

mdp opened this issue Jan 16, 2024 · 2 comments
Labels
bug Something isn't working community triage The issue is new and needs to be triaged by a maintainer

Comments

@mdp
Copy link
mdp commented Jan 16, 2024

Current Behavior

Onboarding says

configu upsert \
--store 'configu' --set 'Development' --schema './get-started.cfgu.json' \
--config 'GREETING=hey' -c 'SUBJECT=Mark Percival' \
&& configu upsert \
--store 'configu' --set 'Development/QA' --schema './get-started.cfgu.json' \
-c 'GREETING=welcome'

But not the 'get-started' flag actually names the config file 'start.cfgu.json' -

configu/ts/packages/cli/src/commands/init.ts

Line 94 in 3ebb70d

return 'start';

Expected Behavior

configu upsert \
--store 'configu' --set 'Development' --schema './start.cfgu.json' \
--config 'GREETING=hey' -c 'SUBJECT=Mark Percival' \
&& configu upsert \
--store 'configu' --set 'Development/QA' --schema './start.cfgu.json' \
-c 'GREETING=welcome'

To Reproduce

Go through the onboarding process, try to run the upsert and eval commands as stated.

Context

Onboarding flow
@mdp mdp added the bug Something isn't working label Jan 16, 2024
@github-actions github-actions bot added triage The issue is new and needs to be triaged by a maintainer community labels Jan 16, 2024
@mdp mdp changed the title Onboarding uses "get Onboarding uses wrong filename "get-started" vs "start" Jan 16, 2024
@RichardAkman RichardAkman mentioned this issue Jan 17, 2024
Open
@RichardAkman
Copy link
Contributor
RichardAkman commented Jan 17, 2024 •
edited
Loading

Thank you for bringing this to our attention! I've created an issue for this in the configu documentation repository and linked this issue to it. This is an issue exclusive to our docs so I will be closing this one. Let me know if you're interested in contributing, if so, make a comment there asking me to assign it to you. If not, we will take care of it as soon as possible.

@rannn505 rannn505 reopened this Jan 21, 2024
@rannn505
Copy link
Contributor

This issue has been resolved with the recent release
The fix has been tested and confirmed to be working as expected.
If you encounter any further issues or have additional questions, please feel free to open a new issue or comment on this thread.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working community triage The issue is new and needs to be triaged by a maintainer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mdp @rannn505 @RichardAkman
0