8000 Resetting the time elapsed does not also reset the ETA · Issue #536 · console-rs/indicatif · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Resetting the time elapsed does not also reset the ETA #536
Closed
@afontenot

Description

@afontenot

I think this is just an oversight, but I want to confirm that instead of sending a PR without justification.

I can se 50B2 e how it would make sense to want to reset the ETA but not the time elapsed. E.g. maybe progress stalled for a while, or something, and you want a clean estimate without resetting the time elapsed counter. On the other hand, I can't imagine wanting to reset the time elapsed for the whole progress bar without expecting that to also reset the ETA. It doesn't make very much sense for the progress bar to say it's only been active 1 minute, when the ETA / bitrate is based on data from the last two minutes.

My thinking is that the Reset::Elapsed mode should also reset ::Eta, but not vice versa, and that both of these should be independent of Reset::All (because you only want to recreate the whole progress bar in specific situations).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0