Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 4 commits
- 3 files changed
- 3 contributors
Commits on May 3, 2022
-
exported const EnvCNIPath should have comment (or a comment on this block) or be unexported Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Commits on May 11, 2022
-
Merge pull request #894 from fujitatomoya/bugfix-20220503-golint-erro…
…r-cnitool cnitool: address golint error
Commits on May 25, 2022
-
invoke: if Result CNIVersion is empty use netconf CNIVersion
The CNI Spec requires plugins to return a CNIVersion in the Result that is the same as the CNIVersion of the incoming CNI config. Empty CNIVersions are specified to map to 0.1.0 (since the first CNI spec didn't have versioning) and libcni handles that automatically. Unfortunately some versions of Weave don't do that and depend on a libcni <= 0.8 quirk that used the netconf version if the result version was empty. This is technically a libcni regression, though the plugin itself is violating the specification. Thus for backwards compatibility assume that if the Result CNIVersion is empty, the netconf CNIVersion should be used as the Result version. Fixes: #895 Signed-off-by: Dan Williams <dcbw@redhat.com>
-
Merge pull request #896 from dcbw/empty-result-version-regression
invoke: if Result CNIVersion is empty use netconf CNIVersion
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.1.0...v1.1.1