8000 Proposal: restart policy · Issue #905 · containerd/containerd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Proposal: restart policy #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AkihiroSuda opened this issue May 25, 2017 · 4 comments
Closed

Proposal: restart policy #905

AkihiroSuda opened this issue May 25, 2017 · 4 comments

Comments

@AkihiroSuda
Copy link
Member

It might be good to put RestartPolicy structure to CreateContainerRequest / UpdateContainerRequest:

message RestartPolicy {
	RestartCondition condition = 1; // "none", "on-failure", (and "any" if needed)
        Duration Delay = 2;
        int64 MaxAttempts = 3;
}

I guess this is useful for linuxkit, cc linuxkit maintainers @ijc25 @justincormack @riyazdf @rneugeba
@Random-Liu
Copy link
Member

@AkihiroSuda Don't think we should do this in containerd. This could be done by the higher level system.

@justincormack
Copy link
Contributor

Not sure if we would use it in LinuxKit - either containers can define their own restarts, or possibly we might add external restart support. But generally I find restart fairly useless, as things that fail normally fail again, and restart rarely helps.

@cpuguy83
Copy link
Member

-1 restart policy seems like a job of a higher level component.
Consider a cluster orchestrator that will just reschedule the container.

@crosbymichael
Copy link
Member

No, this is part of the fundamental design of containerd that it does not handle things like this and provides events and other primitives for higher levels to implement restarts or rescheduling logic.

If you have any questions about overall design and where we positioned containerd in the stack please send me and email or on slack and I'll help you understand better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@justincormack @crosbymichael @cpuguy83 @Random-Liu @AkihiroSuda
0