This repository was archived by the owner on Jun 12, 2024. It is now read-only.
feat: allow customizing http handler error parsing #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose the default Handler implementation and allow customizing the error parsing by passing a new parser function. This allows overriding the error handling but with a reasonable default. Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
c485894 to
8f417a4
Compare
megaflo
reviewed
Apr 26, 2022
Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
megaflo
approved these changes
Apr 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the default Handler implementation and allow customizing the error parsing by passing a new parser function. This allows overriding the error handling but with a reasonable default.
Additionally, change
ValidationErrorsToFiedErrorResponsesignature to accept anymap[string]error. This is the underlying type for avalidation.Error, so it is backwards compatible, but it is also more flexible and will accept more type aliases for validation errors, making it easier to use.Signed-off-by: Lucas Roesler roesler.lucas@gmail.com