From 543ff1d0552be3b5e4ce9cb7f041a86281095df0 Mon Sep 17 00:00:00 2001
From: Michael Armijo <marmijo@redhat.com>
Date: Fri, 16 May 2025 15:01:43 -0600
Subject: [PATCH] tests/platforms: add test for Azure NVMe udev rules

Introduce a new test which verifies that udev rules[1] for Azure
Managed NVMe disks correctly create symlinks in `/dev/disk/azure`.
It only runs on Azure and uses new kola functionality[2] to override
the instance type, enabling the use of a Hyper-V Gen2 VM
(Standard_M16bds_v3) with a UltraSSD_LRS (NVMe) data disk attached.

The test checks for the presence of OS and data disk symlinks, and
that they point to a valid target.

[1]: https://github.com/coreos/fedora-coreos-config/pull/3378
[2]: https://github.com/coreos/coreos-assembler/pull/4109
---
 .../platforms/azure/nvme/data/commonlib.sh    |  1 +
 tests/kola/platforms/azure/nvme/test.sh       | 44 +++++++++++++++++++
 2 files changed, 45 insertions(+)
 create mode 120000 tests/kola/platforms/azure/nvme/data/commonlib.sh
 create mode 100755 tests/kola/platforms/azure/nvme/test.sh

diff --git a/tests/kola/platforms/azure/nvme/data/commonlib.sh b/tests/kola/platforms/azure/nvme/data/commonlib.sh
new file mode 120000
index 0000000000..7028449b11
--- /dev/null
+++ b/tests/kola/platforms/azure/nvme/data/commonlib.sh
@@ -0,0 +1 @@
+../../../../data/commonlib.sh
\ No newline at end of file
diff --git a/tests/kola/platforms/azure/nvme/test.sh b/tests/kola/platforms/azure/nvme/test.sh
new file mode 100755
index 0000000000..18373ea164
--- /dev/null
+++ b/tests/kola/platforms/azure/nvme/test.sh
@@ -0,0 +1,44 @@
+#!/bin/bash
+## kola:
+##   # This test requires changing instance types and must
+##   # be run exclusively.
+##   exclusive: true
+##   # This test is targeted at Azure
+##   platforms: azure
+##   # attach an NVMe data disk to the instance
+##   additionalDisks: ["30G:sku=UltraSSD_LRS"]
+##   # This test requires an instance type that supports NVMe
+##   instanceType: "Standard_M16bds_v3"
+##   description: Verify that udev rules for Azure Managed NVMe disks
+##                correctly create stable symlinks under /dev/disk/azure.
+
+set -xeuo pipefail
+
+. "$KOLA_EXT_DATA/commonlib.sh"
+
+# Wait up to 30 seconds for a symlink to be created.
+wait_for_symlink() {
+    local path="$1"
+    local timeout=30
+    while [ ! -L "$path" ] && [ "$timeout" -gt 0 ]; do
+        sleep 1
+        timeout=$((timeout - 1))
+    done
+    if [ ! -L "$path" ]; then
+        fatal "Timed out waiting for symlink $path to appear"
+    fi
+}
+
+# Verify OS disk symlink
+azure_os_symlink="/dev/disk/azure/os"
+wait_for_symlink "$azure_os_symlink"
+if [ ! -e "$azure_os_symlink" ]; then
+    fatal "symlink $azure_os_symlink exists but points to a missing target"
+fi
+
+# Verify data disk symlink
+azure_data_symlink="/dev/disk/azure/data/by-lun/0"
+wait_for_symlink "$azure_data_symlink"
+if [ ! -e "$azure_data_symlink" ]; then
+    fatal "symlink $azure_data_symlink exists but points to a missing target"
+fi