This repository was archived by the owner on Feb 24, 2020. It is now read-only.
api-service: stop erroring when a pod is running #3525
Merged
8000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand, this is going to assign a 0 exit value isn't it? |
|
It already does. The error message just pollutes stderr - it doesn't change the behavior. |
|
Totally missed that, sorry for the noise
Casey Callendrello <notifications@github.com> schrieb am Di., 10. Jan.
2017, 20:18:
… It already does. The error message just pollutes stderr - it doesn't
change the behavior.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3525 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACewNxDsD0Ye0v1FA1TVAASWQ9eX_st7ks5rQ9lwgaJpZM4LfqZu>
.
|
|
The only failure is our good friend, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3504
This silences this silly error message. This logic isn't exactly correct, but I've filed another issue to fix that.